Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forced rerender from mutator #6918

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix: remove forced rerender from mutator #6918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions core/mutator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,21 +458,7 @@ export class Mutator extends Icon {
const block = this.getBlock();
const oldExtraState = BlockChange.getExtraBlockState_(block);

// Switch off rendering while the source block is rebuilt.
const savedRendered = block.rendered;
// TODO(#4288): We should not be setting the rendered property to false.
block.rendered = false;

// Allow the source block to rebuild itself.
block.compose!(this.rootBlock);
// Restore rendering and show the changes.
block.rendered = savedRendered;
// Mutation may have added some elements that need initializing.
block.initSvg();

if (block.rendered) {
block.render();
}

const newExtraState = BlockChange.getExtraBlockState_(block);
if (oldExtraState !== newExtraState) {
Expand Down