Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a getTargetWorkspace method to flyout_base.ts #7519

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ivalkshfoeif
Copy link
Contributor

@ivalkshfoeif ivalkshfoeif commented Sep 22, 2023

The basics

The details

Resolves

Fixes #7461

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

@ivalkshfoeif ivalkshfoeif requested a review from a team as a code owner September 22, 2023 18:40
@google-cla
Copy link

google-cla bot commented Sep 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to
    validate your changes on our
    developer site.

  • All contributors must sign the Google Contributor License
    Agreement (CLA). If the google-cla bot leaves a comment on this
    PR, make sure you follow the instructions.

  • We use conventional commits
    to make versioning the package easier. Make sure your commit
    message is in the proper format
    or learn how to fix it.

  • If any of the other checks on this PR fail, you can click on
    them to learn why. It might be that your change caused a test
    failure, or that you need to double-check the
    style guide.

Thank you for opening this PR! A member of the Blockly team will review it soon.

@johnnesky
Copy link
Member

johnnesky commented Sep 22, 2023

Please sign the CLA and update the pull request title to start with "feat:" to use conventionalcommits.org. Otherwise it looks good to me, thanks!

@ivalkshfoeif ivalkshfoeif changed the title Add a getTargetWorkspace method to flyout_base.ts feat:Add a getTargetWorkspace method to flyout_base.ts Sep 22, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Sep 22, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Sep 22, 2023
@ivalkshfoeif ivalkshfoeif changed the title feat:Add a getTargetWorkspace method to flyout_base.ts feat: Add a getTargetWorkspace method to flyout_base.ts Sep 22, 2023
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Sep 22, 2023
@johnnesky johnnesky merged commit bb42535 into google:osd Sep 22, 2023
8 checks passed
@johnnesky
Copy link
Member

Nice work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a getTargetWorkspace method to flyout_base.ts
2 participants