Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generators): Fix generator type declarations #7750

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

cpcallen
Copy link
Contributor

@cpcallen cpcallen commented Jan 5, 2024

The basics

The details

Resolves

Fixes #7741

Proposed Changes

Fix incorrect import paths that prevent generators typings from being imported.

Reason for Changes

Non-importable generators are losing.

Test Coverage

First commit is the test; uploading it to get CI to verify that it fails as I'm unable to test locally.

Additional Information

Add a missing ./ prefix to the imports in the generator wrapper
.d.ts files.

Fixes: google#7741
@cpcallen cpcallen marked this pull request as ready for review January 8, 2024 17:03
@cpcallen cpcallen requested a review from a team as a code owner January 8, 2024 17:03
@cpcallen cpcallen requested a review from maribethb January 8, 2024 17:03
@cpcallen cpcallen linked an issue Jan 8, 2024 that may be closed by this pull request
1 task
@cpcallen cpcallen merged commit 4cc4bd5 into google:rc/v11.0.0 Jan 8, 2024
8 checks passed
@cpcallen cpcallen deleted the fix/7741 branch January 8, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import generators in TypeScript in 11.0.0-beta.0
3 participants