Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: have Lua generators use 'nil' instead of 'None' #7837

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Feb 7, 2024

The basics

The details

Resolves

Fixes #6720

Proposed Changes

Makes it so that lua generators use 'nil' instead of 'None'. Reasoning is explained in the linked issue.

Test Coverage

N/A

Documentation

N/A

Additional Information

N/A

Breaking changes

This may break some user's downstream block programs if they are assigning to a variable called 'None' and then initializing lists with empty inputs expecting them to contain the value assigned to None.

It is unlikely that this behavior was ever actually discovered, and as such the correction shouldn't affect end-users.

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Feb 7, 2024
@BeksOmega BeksOmega force-pushed the fix/lua-generators-none branch from d7e20f6 to 772df29 Compare February 7, 2024 17:47
@BeksOmega BeksOmega marked this pull request as ready for review February 7, 2024 17:49
@BeksOmega BeksOmega requested a review from a team as a code owner February 7, 2024 17:49
@BeksOmega BeksOmega requested a review from maribethb February 7, 2024 17:49
@BeksOmega BeksOmega merged commit ad0c0e3 into google:rc/v11.0.0 Feb 7, 2024
8 checks passed
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Feb 9, 2024
@BeksOmega BeksOmega deleted the fix/lua-generators-none branch May 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants