fix: connection previewer disposing too early #7859
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes N/A
Proposed Changes + Reasons
Makes it so the conneciton previewer is disposed after the blocks are connected, because the dynamic connections plugin tears down and rebuilds the block when
disposed
is called. If we dispose before they're connected, the block dragger's connection references are invalid, so the blocks can't actually connect.Test Coverage
Manually tested.
Documentation
N/A
Additional Information
N/A