Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comment position in RTL #7934

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes comments being positioning incorrectly when loading from XML in RTL mode

Proposed Changes + Reasons

Makes it so that comments are positioned relative to the toolbox when loading in RTL mode, to match blocks.

To get this to work the same as blocks I had to change how I was handling RTL in the comment view. We can't apply the scale at the top level because that messes up the transform (we still want +x to go right and +y to go down in RTL mode to match blocks). So I need to apply it to the sub elements of the icon. And to get rotating the foldout icon to work, that meant I needed an element to encompass the elements of the top bar.

Test Coverage

Manually tested loading and saving in RLT and LTR in JSON and XML

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added the PR: fix Fixes a bug label Mar 13, 2024
@BeksOmega BeksOmega force-pushed the fix/comment-pos-rtl branch 4 times, most recently from d09cbe2 to 30ef460 Compare March 18, 2024 17:39
@BeksOmega BeksOmega force-pushed the fix/comment-pos-rtl branch from 30ef460 to 07ba954 Compare March 20, 2024 23:29
@BeksOmega BeksOmega marked this pull request as ready for review March 21, 2024 18:14
@BeksOmega BeksOmega requested a review from a team as a code owner March 21, 2024 18:14
@BeksOmega BeksOmega requested a review from cpcallen March 21, 2024 18:14
@cpcallen cpcallen changed the title fix: comment pos rtl fix: comment position in RTL Mar 22, 2024
@github-actions github-actions bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels Mar 22, 2024
@BeksOmega BeksOmega merged commit d01f9a7 into google:rc/v11.0.0 Mar 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants