Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have blocks use drag strategy #7971

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Mar 28, 2024

The basics

The details

Resolves

Fixes #7841

Proposed Changes

Has the BlockSvg delegate to a IDragStrategy (which external devs can supply). This makes the blocks use the new drag system, and allows external devs to customize how blocks handle drags.

Test Coverage

Tested manually with a following PR that updates the gesture system to use the dragger and raggables.

Documentation

N/A

Additional Information

N/A

@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Mar 28, 2024
@BeksOmega BeksOmega force-pushed the feat/drag-block-use-strat branch from eb60585 to 0727367 Compare March 28, 2024 20:25
@BeksOmega BeksOmega force-pushed the feat/drag-block-use-strat branch from 0727367 to 41f9a94 Compare March 28, 2024 23:06
@BeksOmega BeksOmega marked this pull request as ready for review March 28, 2024 23:12
@BeksOmega BeksOmega requested a review from a team as a code owner March 28, 2024 23:12
@BeksOmega BeksOmega merged commit 75fc470 into google:rc/v11.0.0 Mar 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants