feat: visual comment selection #7996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
force-pushed
the
feat/comment-selection
branch
from
b7532d9 to
1186c9d
Compare
BeksOmega
force-pushed
the
feat/comment-selection
branch
from
1186c9d to
b95530d
Compare
BeksOmega
requested review from
rachel-fenichel
and removed request for
maribethb
github-actions
bot
added
PR: feature
| @@ -124,6 +131,14 @@ export class CommentView implements IRenderedElement { | |||
| this.moveTo(new Coordinate(0, 0)); | |||
| } | |||
|
|
|||
| private createHighlightRect(svgRoot: SVGGElement): SVGRectElement { | |||
There was a problem hiding this comment.
Do we want to turn the lint warnings for this back on?
rachel-fenichel
approved these changes
Apr 5, 2024
johnnesky
pushed a commit
to johnnesky/blockly
that referenced
this pull request
Apr 13, 2024
* feat: add visually highlighting selected comment * chore: TSDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #8007
Proposed Changes
Adds visually highlighting workspace comments when they are selected
Test Coverage
Documentation
N/A
Additional Information
N/A