Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264) #8308

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ga-fleury
Copy link

@ga-fleury ga-fleury commented Jul 11, 2024

Fixes: #8264

feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)

@ga-fleury ga-fleury requested a review from a team as a code owner July 11, 2024 12:10
@ga-fleury ga-fleury requested a review from BeksOmega July 11, 2024 12:10
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Jul 11, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix =)

Once this passes CI I'll get it merged!

@BeksOmega
Copy link
Collaborator

Looks like this is failing formatting. Please fix the same way I suggested on the other PR!

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as changes requested

@BeksOmega
Copy link
Collaborator

Heya @ga-fleury Are you still interested in working on this?

@ga-fleury
Copy link
Author

@BeksOmega format changes pushed

Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great =) Thanks for your work on this!

@BeksOmega BeksOmega merged commit 348313a into google:rc/v12.0.0 Jul 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants