-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a blocklyShadow class #8336
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! To remove the commits that aren't yours, you can rebase your branch on top of the latest rc/v12.0.0
branch. This will remove any commits that were added to rc/v12.0.0
since you created your branch.
Here are the steps to do that:
-
Fetch the latest changes from
rc/v12.0.0
:git fetch upstream rc/v12.0.0
-
Checkout your branch:
git checkout [your-branch-name]
-
Start an interactive rebase:
git rebase -i upstream/rc/v12.0.0
-
In the editor that opens, identify the commits that aren't yours. These are likely the ones at the top of the list.
-
Change the word
pick
todrop
for each commit you want to remove. -
Save and close the editor.
-
Force push your changes to your branch: Note that force pushing is a dangerous operation because it overwrites commit history, so if you dropped the wrong commits you could lose work.
git push -f origin [your-branch-name]
Once you've done this, the PR should only contain your commits.
Let me know if you have any questions or run into any issues!
@BeksOmega Thanks a lot for the suggestion. It worked! |
Hiya @devesh-2002 Can you run |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just pushing the changes to your files is perfect! Thank you for the fix this looks great =)
The basics
The details
Resolves
Fixes #8262,
Proposed Changes
Added a blocklyShadow CSS class to shadow blocks' root SVG
Reason for Changes
Test Coverage
Documentation
Additional Information
Please let me know, if any changes are needed.
Also, I am not sure why is it showing 4 commits, I only added in the
path_object.ts