fix!: Rename blocklyTreeRow and blocklyToolboxCategory CSS classes

[Abhinav-Chdhary]

The basics

• I validated my changes

The details

• This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory.
• The commit was made against v12.0.0 branch
• It is a breaking change

Fixes #8345

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[github-actions]

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

• You can find tips about contributing to Blockly and how to validate your changes on our developer site.
• All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
• We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
• If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
  Thank you for opening this PR! A member of the Blockly team will review it soon.

[BeksOmega]

Thanks for digging into this! Just a few fixes then should be gtg.

[BeksOmega]

Thanks for the fixes! But now it looks like some Mocha tests are failing. Could you look into what's going wrong? You can run them locally by doing npm run test:mocha:interactive.

[Abhinav-Chdhary]

Thanks for the fixes! But now it looks like some Mocha tests are failing. Could you look into what's going wrong? You can run them locally by doing npm run test:mocha:interactive.

Yes definitely! Can you help me understand these errors?

I had also made the changes in test files, so that it simulates the click on blocklyToolboxCategory instead of blocklyTreeRow. That was the correct step right?

[BeksOmega]

Ah I see the issue, this is my bad. We've created a conflict between the CSS class of the container and the CSS class of the row. Could you name the original uses of blocklyToolboxCategory to blocklyToolboxCategoryContainer as well? I think that should fix the problem!

[Abhinav-Chdhary]

Ah I see the issue, this is my bad. We've created a conflict between the CSS class of the container and the CSS class of the row. Could you name the original uses of blocklyToolboxCategory to blocklyToolboxCategoryContainer as well? I think that should fix the problem!

I have tried to do so. It passes all tests locally.

[BeksOmega]

Sweetness! Thank you for the back and forth, this looks beautiful =)