Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add blocklyMiniWorkspaceBubble css class #8390

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: add blocklyMiniWorkspaceBubble css class #8390

merged 1 commit into from
Jul 22, 2024

Conversation

ishon19
Copy link

@ishon19 ishon19 commented Jul 18, 2024

The basics

The details

This PR add blocklyMiniWorkspaceBubble css class to the MiniWorkspaceBubble constructor.

Fixes #8340

@ishon19 ishon19 requested a review from a team as a code owner July 18, 2024 06:00
@ishon19 ishon19 requested a review from BeksOmega July 18, 2024 06:00
@github-actions github-actions bot added the PR: feature Adds a feature label Jul 18, 2024
BeksOmega
BeksOmega approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for the fix =) Once this passes CI I'll get it merged =)

@ishon19
Copy link
Author

ishon19 commented Jul 22, 2024

This looks great! Thank you for the fix =) Once this passes CI I'll get it merged =)

Awesome, thanks for the review @BeksOmega!

@BeksOmega BeksOmega merged commit fb82c9c into google:rc/v12.0.0 Jul 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishon19 @BeksOmega