Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a blocklyNotEditable CSS class to the block's root SVG #8391

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

dianaPrahoveanu-SL
Copy link

Code Changes:

  • Added a condition in the setEditable method to check the editability of the block.
  • Utilized dom.addClass to add the blocklyNotEditable class when this.editable_ is false.
  • Utilized dom.removeClass to remove the blocklyNotEditable class when this.editable_ is true.

Fixes #8266

@dianaPrahoveanu-SL dianaPrahoveanu-SL requested a review from a team as a code owner July 18, 2024 09:48
Copy link

google-cla bot commented Jul 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added the PR: feature Adds a feature label Jul 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko July 18, 2024 15:24
@BeksOmega BeksOmega assigned BeksOmega and unassigned gonfunko Jul 18, 2024
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great thank you for the fixes! Once this passes CI I'll get it merged =)

I have a feeling it might fail formatting. You can fix that by running npm run format in the root of the repository and then comitting the changes.

@BeksOmega
Copy link
Collaborator

Sweet! Thank you so much for the fix :D

@BeksOmega BeksOmega merged commit 2619fb8 into google:rc/v12.0.0 Jul 23, 2024
7 checks passed
@dianaPrahoveanu-SL
Copy link
Author

Thank you for merging my PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature Adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants