-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Rename blocklyTreeIconOpen to blocklyToolboxCategoryIconOpen
#8440
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Heya @UtkershBasnet in the future we ask that folks ask to be assigned to issues before completing them! Otherwise it's not fair to the other folks that may be working on it. If you do that in the future, I'll have to close your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good =) Thank you for the fix!
@BeksOmega Thank you for the feedback and for reviewing my PR! I apologize for not asking to be assigned to the issue before completing it. I understand the importance of maintaining fairness in the process and will make sure to follow this protocol in the future. I'm glad the change looks good to you! Thank you for the review and for your guidance. |
blocklyToolboxCategoryIconOpen
Ah sorry, just noticed this is against the wrong branch @UtkershBasnet To rebase onto the rc/v12.0.0 branch, you can follow these steps.
Once you've done this, the PR should be on the correct branch. Let me know if you have any questions or run into any issues! |
302f0f6
to
c7ad538
Compare
Can you try it with this slightly modified set of commands? (1 and 2 are changed)
|
ad70380
to
886a113
Compare
I think the problem was in my branch i removed the commits that weren't mine in my own branch using the
|
Thank you again for your work on this! |
The basics
The Details
The pull request renames all references to blocklyTreeIconOpen to blocklyToolboxCategoryIconOpen
Resolves
Fixes #8348