Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField #8475

Merged
merged 1 commit into from
Aug 12, 2024
Merged

feat!: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField #8475

merged 1 commit into from
Aug 12, 2024

Conversation

Adityajaiswal03
Copy link

solve #8290

@Adityajaiswal03 Adityajaiswal03 requested a review from a team as a code owner August 9, 2024 06:44
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Aug 9, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@github-actions github-actions bot added the PR: feature Adds a feature label Aug 9, 2024
@Adityajaiswal03 Adityajaiswal03 changed the title feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. Aug 9, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 9, 2024
@Adityajaiswal03 Adityajaiswal03 changed the title feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. Aug 9, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 9, 2024
@Adityajaiswal03 Adityajaiswal03 changed the title feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField Aug 9, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 9, 2024
@Adityajaiswal03 Adityajaiswal03 changed the title feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. Aug 9, 2024
@github-actions github-actions bot added PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 9, 2024
@Adityajaiswal03
feat: change blocklyEditableText to blocklyEditableField and blocklyN…
337706e 
…onEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers.
@Adityajaiswal03
Copy link
Author

Hi @BeksOmega,

I’ve submitted a new PR. Could you please take a look and provide your feedback?

@Adityajaiswal03
Copy link
Author

@gonfunko
Could you please review the PR and share your feedback when you get a chance? I’d really appreciate it.

@BeksOmega BeksOmega requested review from BeksOmega and removed request for gonfunko August 12, 2024 16:44
@BeksOmega BeksOmega assigned BeksOmega and unassigned gonfunko Aug 12, 2024
@BeksOmega BeksOmega changed the title feat: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField BREAKING CHANGE: The blocklyEditableText and blocklyNonEditableText identifiers have been renamed to blocklyEditableField and blocklyNonEditableField respectively. This change may require updates to any existing code that references the old identifiers. feat!: change blocklyEditableText to blocklyEditableField and blocklyNonEditableText to blocklyNonEditableField Aug 12, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature and removed PR: feature Adds a feature labels Aug 12, 2024
BeksOmega
BeksOmega approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great =) Once this passes CI I'll get it merged! Thank you for your work on this.

@BeksOmega BeksOmega merged commit 59fab94 into google:rc/v12.0.0 Aug 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeksOmega BeksOmega BeksOmega approved these changes

Assignees

@BeksOmega BeksOmega

Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: feature Adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Adityajaiswal03 @BeksOmega @gonfunko