Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix flaky connection checker test. #8754

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

gonfunko
Copy link
Contributor

The basics

The details

Resolves

Fixes #8688

Proposed Changes

This PR resolves a flaky test that was triggered by identifying blocks based on their position rather than their identifiers.

@gonfunko gonfunko requested a review from a team as a code owner January 30, 2025 23:26
@github-actions github-actions bot added the PR: fix Fixes a bug label Jan 30, 2025
@gonfunko gonfunko merged commit 34da1da into google:develop Jan 31, 2025
11 checks passed
@gonfunko gonfunko deleted the frosted-unflakes branch January 31, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection_checker_test.js has flaky tests
2 participants