Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle rc files prefering local over global to make clasp more CI friendly #486

Closed
wants to merge 5 commits into from

Conversation

johnnyasantoss
Copy link
Contributor

Tries to fix #483

  • npm run test succeeds.
  • npm run lint succeeds.
  • Appropriate changes to README are included in PR.

@grant I've found the file ./src/auth.ts kinda of "hacky" and there's a lot of things that just seems out of place. Can you help me?
btw: I don't know if there's a motivation to only use global files, but I've assumed that my proposition of trying to make this tool more aware of local rc file is valid.

@grant
Copy link
Contributor

grant commented Jan 10, 2019

@johnnyasantoss Thanks for trying to help but this PR does too many things at once.
What specifically do you mean hacky?
Can you make smaller PRs and not have both prettier changes and auth changes in the same PR?

@grant
Copy link
Contributor

grant commented Jan 14, 2019

Closed due to inactivity.

@grant grant closed this Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local .clasprc.json Support
3 participants