Remove special-case handling of goog.global now that it is marked @const

------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=188940343
google · Mar 14, 2018 · 4a6cbb1 · 4a6cbb1
1 parent 7dc5f04
commit 4a6cbb1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/com/google/javascript/jscomp/ijs/PotentialDeclaration.java b/src/com/google/javascript/jscomp/ijs/PotentialDeclaration.java
@@ -255,7 +255,6 @@ boolean shouldPreserve() {
           || isImportRhs(rhs)
           || (isExport && rhs != null && (rhs.isQualifiedName() || rhs.isObjectLit()))
           || (jsdoc != null && jsdoc.isConstructor() && rhs != null && rhs.isQualifiedName())
-          || (nameNode.matchesQualifiedName("goog.global") && rhs != null && rhs.isThis())
           || (rhs != null
               && rhs.isObjectLit()
               && !rhs.hasChildren()

diff --git a/test/com/google/javascript/jscomp/ijs/ConvertToTypedInterfaceTest.java b/test/com/google/javascript/jscomp/ijs/ConvertToTypedInterfaceTest.java
@@ -1434,7 +1434,7 @@ public void testRedeclarationOfClassMethodDoesntCrash() {
   }
 
   public void testGoogGlobalTyped() {
-    testSame("/** @const */ var goog = {}; goog.global = this;");
+    testSame("/** @const */ var goog = {}; /** @const */ goog.global = this;");
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -1434,7 +1434,7 @@ public void testRedeclarationOfClassMethodDoesntCrash() { @@
       }
       public void testGoogGlobalTyped() {
-        testSame("/** @const */ var goog = {}; goog.global = this;");
+        testSame("/** @const */ var goog = {}; /** @const */ goog.global = this;");
       }
@@ Expand Down @@