Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Add support for file based targets discovery #394

Closed
manugarg opened this issue Apr 17, 2020 · 2 comments
Closed

Add support for file based targets discovery #394

manugarg opened this issue Apr 17, 2020 · 2 comments
Assignees
Milestone

Comments

@manugarg
Copy link
Contributor

It will be similar to prometheus's file based service discovery:
https://prometheus.io/docs/guides/file-sd/

@manugarg manugarg self-assigned this Jun 14, 2020
@manugarg
Copy link
Contributor Author

Started working on this.

@manugarg manugarg added this to the v0.10.8 milestone Jun 14, 2020
manugarg added a commit that referenced this issue Jun 20, 2020
File targets will allow users to list targets, and their labels, IP, and port, in a file in text proto (rds.Resource) and JSON format.

This is an externally requested feature:
#394

I can also imagine this being useful for some of the internal probers.

PiperOrigin-RevId: 317439552
manugarg added a commit that referenced this issue Jun 20, 2020
File targets will allow users to list targets, and their labels, IP, and port, in a file in text proto (rds.Resource) and JSON format.

This is an externally requested feature:
#394

I can also imagine this being useful for some of the internal probers.

PiperOrigin-RevId: 317440110
@manugarg
Copy link
Contributor Author

manugarg commented Jul 2, 2020

I should probably document this. For now, there are some examples here: https://github.com/google/cloudprober/blob/master/targets/file/file_test.go

I'll close this issue now. I've filed a separate bug to track the release: #425.

@manugarg manugarg closed this as completed Jul 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant