Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Datagram socket ping (unprivileged ping) over IPv4 is broken for MacOS #537

Closed
manugarg opened this issue Dec 21, 2020 · 1 comment · Fixed by #539
Closed

Datagram socket ping (unprivileged ping) over IPv4 is broken for MacOS #537

manugarg opened this issue Dec 21, 2020 · 1 comment · Fixed by #539
Assignees
@manugarg
Labels
bug
Milestone
v0.11.2

Comments

@manugarg
Copy link
Contributor

While investigating #531 (also as mentioned in the bug report) I found that unprivileged ping (datagram socket based ping) is broken on MacOS, but only for IPv4.

W1221 13:19:53.246066 94333 ping.go:330] read udp 0.0.0.0:0: raw-read udp 0.0.0.0:0: i/o timeout
1608585592 labels=ptype=ping,probe=ping,dst=www.google.com total=2 success=0 latency=0.000 validation_failure=map:validator,data-integrity:0
1608585592 labels=ptype=ping,probe=ping,dst=www.yahoo.com total=2 success=0 latency=0.000 validation_failure=map:validator,data-integrity:0
W1221 13:19:55.243723 94333 ping.go:330] read udp 0.0.0.0:0: raw-read udp 0.0.0.0:0: i/o timeout
@manugarg manugarg added the bug label Dec 21, 2020
@manugarg manugarg mentioned this issue Dec 21, 2020
Closed
@manugarg manugarg self-assigned this Dec 21, 2020
@manugarg
Copy link
Contributor Author

I've sent a change for review to fix this.

@manugarg manugarg added this to the v0.11.2 milestone Dec 22, 2020
manugarg added a commit that referenced this issue Dec 22, 2020
@manugarg
For OS X, compute checksum for IPv4 SOCK_DGRAM sockets as well.
9063cc7 
Darwin kernel never seems to compute checksum for IPv4.

Fixes: #537
PiperOrigin-RevId: 348598094
@manugarg manugarg mentioned this issue Dec 22, 2020
Merged
manugarg added a commit that referenced this issue Dec 22, 2020
@manugarg
For OS X, compute checksum for IPv4 SOCK_DGRAM sockets as well. (#539)
34627fb 
Darwin kernel never seems to compute checksum for IPv4.

Fixes: #537
PiperOrigin-RevId: 348598094
@manugarg manugarg mentioned this issue Apr 12, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@manugarg manugarg

Labels
bug
Projects
None yet
Milestone
v0.11.2
Development

Successfully merging a pull request may close this issue.

For OS X, compute checksum for IPv4 SOCK_DGRAM sockets as well. google/cloudprober
1 participant
@manugarg