This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Allow for request bodies larger than 32768 bytes. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently request body reader returns io.EOF on the first "Read" itself. Default HTTP transport seems to use a byte slice of size 32768, which results in request body being truncated to 32768 bytes. This change fixes that problem by using a buffered reader if request body is larger than a certain threshold (set to bytes.MinRead, same as used by ioutil.ReadAll). PiperOrigin-RevId: 325915715
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently request body reader returns io.EOF on the first "Read" itself. Default HTTP transport seems to use a byte slice of size 32768, which results in request body being truncated to 32768 bytes.
This change fixes that problem by using a buffered reader if request body is larger than a certain threshold (set to bytes.MinRead, same as used by ioutil.ReadAll).
PiperOrigin-RevId: 325915715