Fixed pointer bug in ListProbes() method in serviceimpl.go and the corresponding test.

[evanSpendlove]

There is a pointer issue in the ListProbes() RPC. The ListProbesResponse object contains a list of structs, each containing a string and ProbeInfo object. If there are multiple probes added, the strings will all be the same as the last item added to this list.

Example:
3 probes (probe0, probe1, probe2) are added.
ListProbes() is called.

Desired Response: ["probe0" , "probe1" , "probe2" ]
Received Response: ["probe2" , "probe2" , "probe2" ]

There is also a minor bug in the serviceimpl_test.go file.

cloudprober/prober/serviceimpl_test.go

Lines 185 to 187 in 4cbdccb

	if reflect.DeepEqual(respProbeNames, testProbes) {
	t.Errorf("Probes in ListProbes() response: %v, expected: %s", respProbeNames, testProbes)
	}

There is a missing negation (!) in the if statement above, it should be:

if !reflect.DeepEqual(respProbeNames, testProbes) {
		t.Errorf("Probes in ListProbes() response: %v, expected: %s", respProbeNames, testProbes)
	}

Without the negation, this will only throw an error when these are the same, rather than different.

This pull request addresses both of these issues.

[manugarg]

Thanks for finding the bug, and the fix. One suggestion.

[manugarg]

Submitted this change (baf6337) through #461.