Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Docs: Filtering Metrics in Surfacers #598

Merged
merged 1 commit into from
May 6, 2021
Merged

Docs: Filtering Metrics in Surfacers #598

merged 1 commit into from
May 6, 2021

Conversation

robpickerill
Copy link
Contributor

@robpickerill robpickerill commented May 1, 2021

Staging this PR to align filtering docs as a follow on for #597. I'd spotted the cloudwatch docs needed a quick update so I took the opportunity to also write a bit of documentation for filtering metrics.

I'd also spotted I'd missed the surfacers overview -> cloudwatch reference so added that here.

There is a minor code change in the protobuf config and tests for cloudwatch so I think this PR needs splitting again? Let me know what's best.

@google-cla
Copy link

google-cla bot commented May 1, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 1, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@robpickerill robpickerill changed the title Filtering docs Docs: Filtering Metrics in Surfacers May 1, 2021
Copy link
Contributor

@manugarg manugarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. One minor suggestion.

docs/content/surfacers/overview.md Outdated Show resolved Hide resolved
@manugarg
Copy link
Contributor

manugarg commented May 4, 2021

@robpickerill Can you remove protobuf and Go change from this PR. Submitting them through:
#600

@manugarg
Copy link
Contributor

manugarg commented May 5, 2021

@robpickerill Any chance you can squash your commits into one? I can try doing it but it will be another pull request / direct commit (with you still as author) again.

@robpickerill
Copy link
Contributor Author

robpickerill commented May 6, 2021

@robpickerill Any chance you can squash your commits into one? I can try doing it but it will be another pull request / direct commit (with you still as author) again.

I squashed and reworded the commit message for the cleaner commit history - apologies for the messy history, but now fixed :)

@manugarg manugarg merged commit 30b000a into google:master May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants