Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BSv5] Drop import of rtl/main #1443

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[BSv5] Drop import of rtl/main #1443

merged 1 commit into from
Feb 27, 2023

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 25, 2023 •
edited
Loading

  • As is mentioned in the changelog, this drops the BSv5-incompatible RTL support we had before. We drop the rtl/main import from the main SCSS file, but keep the rtl style files for now.
  • Contributes to Reintroduce RTL support using BSv5 RTLCSS #1442, which we'll use to track progress of RTL-support reintroduction
  • View diff by ignoring whitespace changes

@chalin chalin requested a review from geriom February 25, 2023 20:23
This was referenced Feb 25, 2023
Closed
Closed
geriom
geriom approved these changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@geriom geriom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chalin chalin merged commit 0edc7d6 into google:main Feb 27, 2023
@chalin chalin deleted the chalin-im-rtl-2023-02-25 branch February 27, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geriom geriom geriom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @geriom