Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BSv5] Set tables to display:block and explain why #1477

Merged
merged 3 commits into from
Mar 10, 2023

Conversation

Small tweaks - broke up a couple of sentences, also put the bit about Bootstrap's recommendation into a note as it's not *absolutely* necessary to use the feature but might be interesting to some readers.
@@ -241,25 +241,28 @@ of the following:

## Tables

By default, Docsy applies the following styles (through the class `.td-table`)
to all tables:
By default, Docsy applies the following styles to all tables, through the class `.td-table`:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, better! Thanks.

@chalin
Copy link
Collaborator Author

chalin commented Mar 10, 2023

I love your edits @LisaFC, thanks again. I fixed a link and made a few more tweaks (e.g., dropped the term "default" since it's Docsy's styling of tables period no default since there's no other styling that Docsy applies). I hope that's ok with you. I'll merge now. Followup comment are still welcome.

@chalin chalin merged commit b1ad3a7 into google:main Mar 10, 2023
@chalin chalin deleted the chalin-im-resp-tables-2023-03-10 branch March 10, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BSv5] Ensure tables are responsive by default
2 participants