[BSv5] Footer: drop flex-shrink tweak + other adjustments #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
force-pushed
the
chalin-im-foot-adj-2023-05-26
branch
from
f3226c4
to
b006a7d
Compare
7 tasks
chalin
force-pushed
the
chalin-im-foot-adj-2023-05-26
branch
from
b006a7d
to
3565e60
Compare
chalin
commented
May 26, 2023
Comment on lines
+42
to
+44
| - `$list-inline-padding` is increased in support of footer icons ([#1523]). If | ||
| this global adjustment is a problem for your project, let us know and we can | ||
| contextualize the adjustment to the footer. |
There was a problem hiding this comment.
@LisaFC et al.: note the design decision of making a global parameter adjustment (the simplest change), but asking projects for feedback in case it causes problems for them.
There was a problem hiding this comment.
That makes sense to me - I'm sure people will report back if it breaks anything and it doesn't seem to have done so in our site.
|
Oh yes, that looks much better, thanks Patrice! |
LisaFC
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flex-shrinktweak. This is possible by moving the margin adjustment from the footer container to the row element.sm) to match main page content breakpoint (md) inmx-md-*mx-2) around list inline elements, since the base inline list style provides sufficient margins appropriately tuned for list items.Preview: https://deploy-preview-1523--docsydocs.netlify.app
Screenshots
Showing breakpoint mismatch between page content and footer layout.
Before:
After: