Add flags to control trailing decimal and zero in exponent form when input has one significant digit #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
CLA is now signed. |
|
Thanks for the PR.
|
|
Happy to make this a separate flag. Any suggestions for what to name it? 😅 |
|
I would keep it simple:
wdyt? |
ianmcook
changed the title
EMIT_TRAILING_DECIMAL_POINT, EMIT_TRAILING_ZERO_AFTER_POINT
|
@floitsch PTAL |
ianmcook
commented
May 15, 2023
Closed
3 tasks
kou
pushed a commit
to apache/arrow
that referenced
this pull request
Jun 9, 2023
…, remove patches (#36002) [double-conversion v3.3.0](https://github.com/google/double-conversion/releases/tag/v3.3.0) adds a [new feature](google/double-conversion#195) that allows us to remove the special code that was added to our vendored copy of double-conversion in #9816. This PR: * Updates vendored double-conversion to v3.3.0 * Activates the new flags `EMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIAL` and `EMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIAL` * Removes the patches in `cpp/src/arrow/vendored/double-conversion/patches` ----- * Closes: #35669 Authored-by: Ian Cook <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements an improvement in how theThis adds new flagsEMIT_TRAILING_DECIMAL_POINTandEMIT_TRAILING_ZERO_AFTER_POINTflags affectEMIT_TRAILING_DECIMAL_POINT_IN_EXPONENTIALandEMIT_TRAILING_ZERO_AFTER_POINT_IN_EXPONENTIALto control the trailing decimal and zero in conversion to scientific notation when the input number has exactly one significant digit.These flags control the behavior of
ToShortest()andToPrecision(, 1)which currently do not respect the existing flagsEMIT_TRAILING_DECIMAL_POINTandEMIT_TRAILING_ZERO_AFTER_POINTin this situation.ToExponential()OTOH does respect the existing flags in this situation, and its behavior is unaffected by these new flags.For example: when both of the new flags are activated,
ToShortest(0.00001)andToPrecision(0.00001, 1)both currently emit1E-5, but after this PR they both emit1.0E-5.This change was originally made in Apache Arrow's vendored copy of double-conversion in apache/arrow#9816. The Apache Arrow developers would like to contribute this improvement upstream so that we can depend directly on upstream double-conversion. Thank you.