Fix PHP byte validation and reenable builds #7670
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI builds for PHP were disabled in #6381 and sometime later removed.
This PR fixes the byte validation error and re-introduces the (updated) build.
The byte validation error was caused by attempting to check if:
coming from this line, which evaluates false, instead validating on the ord value for bytes we can compare like for like:
which allows the value to be treated as a valid, in range, byte.
Test's also needed a couple of fixes to pass but they looked like bugs.
Testing: