Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Optimize worker support code #153

Open
taymonbeal opened this issue Jun 4, 2021 · 2 comments
Open

Optimize worker support code #153

taymonbeal opened this issue Jun 4, 2021 · 2 comments

Comments

@taymonbeal
Copy link
Member

As of #20, the source code is just included verbatim as a string in the binary, with no minification or anything. This is clearly undesirable. To fix it we're going to have to figure out some Webpack stuff.
@taymonbeal taymonbeal mentioned this issue Jun 4, 2021
Merged
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 4, 2021
@taymonbeal
Introduce bidding worklets
8358574 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
@jeffkaufman
Copy link
Contributor

I'm not convinced we need to fix this? It's not perfect, but the shim is a short term project and the performance overhead of this should be quite low?

@taymonbeal
Copy link
Member Author

Oh yeah, there's another reason, which is that if/when we adopt tsec it won't cover the worker support code if it's just a string in the binary. This seems like not what we want; we'd rather get the security benefits of tsec for all the code.

taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
ea10d6e 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
089ba5d 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
60e1a02 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
04cb964 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
4c5bbd0 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit to taymonbeal/fledge-shim that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets
011a39e 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (google#147)
- trustedBiddingSignalsKeys (google#148)
- auctionSignals (google#149)
- browserSignals (google#150)
- Timeouts (google#151)
- Deduplication of script fetches (google#152)
- Optimization of worker support code (google#153)
- Public TypeScript typings for worklet script authors (google#154)

Fixes: google#20
taymonbeal added a commit that referenced this issue Jun 8, 2021
@taymonbeal
Introduce bidding worklets (#155)
4a05ecc 
This is the minimum working implementation. Features to be added later include:
- Arbitrary metadata instead of just a static price (#147)
- trustedBiddingSignalsKeys (#148)
- auctionSignals (#149)
- browserSignals (#150)
- Timeouts (#151)
- Deduplication of script fetches (#152)
- Optimization of worker support code (#153)
- Public TypeScript typings for worklet script authors (#154)

Fixes: #20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffkaufman @taymonbeal