This repository has been archived by the owner on Jul 23, 2022. It is now read-only.
Rework trusted signal fetching #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Our escaping and query string behavior are now aligned with (my best understanding of) Chrome's. - Iteration order of ads and interest groups, and the security implications thereof, are now documented. Fixes: google#69
jeffkaufman
approved these changes
May 27, 2021
| * by interest group name and then by the order given in the | ||
| * `joinAdInterestGroup` call, with only the first kept in case of duplicates. | ||
| * This leaks some information about interest groups and when they were joined | ||
| * to the trusted server, but that's okay, since it's trusted. |
There was a problem hiding this comment.
Why not just sort by renderingUrl? Then we leak nothing.
(if there's some reason this is impractical, that's probably OK, but the sort seems pretty easy?)
| * @param hostname The hostname of the page where the FLEDGE Shim API is | ||
| * running. | ||
| */ | ||
| export async function runAdAuction( | ||
| trustedScoringSignalsUrl: string | null, | ||
| // This is temporary until trustedBiddingSignalsUrl is added. | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| hostname: string |
There was a problem hiding this comment.
For what it's worth, I think Chrome probably is going to provide hostname
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #69