Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do something about empty output directory fields in trace dialog #972

Closed
ben-clayton opened this issue Aug 22, 2017 · 0 comments
Closed

Do something about empty output directory fields in trace dialog #972

ben-clayton opened this issue Aug 22, 2017 · 0 comments
Assignees
@pmuetschard
Labels
GAPIC P2 triaged
Milestone
V0.8 (Beta)

Comments

@ben-clayton
Copy link
Contributor

This week I've had two reports of people unable to trace because they left the output directory field blank when attempting to take a trace.

For unix systems this attempts to write to the root directory: /foo.gfxtrace
For windows this attempts to write to the system32 directory: c:\windows\system32 (?!)

We should either prevent people from clicking okay, or default to a sensible location.
@ben-clayton ben-clayton added this to the V0.9 (Beta) milestone Aug 22, 2017
pmuetschard added a commit to pmuetschard/gapid that referenced this issue Aug 23, 2017
@pmuetschard
Require the directory to be non-empty in the trace dialog.
07af010 
Fixes google#972
@pmuetschard pmuetschard mentioned this issue Aug 23, 2017
Merged
pmuetschard added a commit that referenced this issue Aug 23, 2017
@pmuetschard
Require the directory to be non-empty in the trace dialog.
8289445 
Fixes #972
purvisa-at-google-com pushed a commit that referenced this issue Sep 29, 2022
Add 'splash screen' to replayer activity (#972)
91d5a2a 
* Add content view for replayer activity

* Fixed copyright msg and cleaned up dup files

* Fix copyright year
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmuetschard pmuetschard

Labels
GAPIC P2 triaged
Projects
None yet
Milestone
V0.8 (Beta)
Development

No branches or pull requests
2 participants
@ben-clayton @pmuetschard