Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Vulkan layer via settings regardless of GLES layer support #3713

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

hevrard
Copy link
Contributor

@hevrard hevrard commented Jan 30, 2020

The logic to decide how to load the Vulkan interception layer was
based on GLES layer support. This change separates the two APIs, such
that the system settings are use to load the Vulkan interception layer
as soon as the Android version allows it, regardless of GLES layer
support.

Bug: b/147723153#comment61

The logic to decide how to load the Vulkan interception layer was
based on GLES layer support. This change separates the two APIs, such
that the system settings are use to load the Vulkan interception layer
as soon as the Android version allows it, regardless of GLES layer
support.
Copy link
Contributor

@johnplate johnplate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but Andrew should confirm.

@hevrard hevrard requested a review from pmuetschard January 30, 2020 16:53
Copy link
Member

@pmuetschard pmuetschard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CDD requires the EGL_ANDROID_GLES_layers extension, so I don't really see how this is an issue, but ok.

@hevrard hevrard merged commit 2ec7aed into google:master Jan 30, 2020
pmuetschard pushed a commit to pmuetschard/gapid that referenced this pull request Jan 31, 2020
…le#3713)

The logic to decide how to load the Vulkan interception layer was
based on GLES layer support. This change separates the two APIs, such
that the system settings are use to load the Vulkan interception layer
as soon as the Android version allows it, regardless of GLES layer
support.

Bug: b/147723153#comment61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants