-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Python toolchain in MODULE.bazel conflicts with downstream registered versions #4581
Comments
Thank you for reporting. It looks like you are correct. This will be patched soon. |
Expect to see a 1.15.1 patch release soon. (Edit: Actually fixed in 1.15.2) |
copybara-service bot
pushed a commit
to abseil/abseil-cpp
that referenced
this issue
Aug 1, 2024
This updates to a version of GoogleTest that fixes google/googletest#4581 for downstream users of rules_python PiperOrigin-RevId: 658398482 Change-Id: I4c6d431fd38d3a108e3c252eb26be9d81ff05a8e
derekmauro
added a commit
to derekmauro/abseil-cpp
that referenced
this issue
Aug 1, 2024
This updates to a version of GoogleTest that fixes google/googletest#4581 for downstream users of rules_python Cherry-pick of d0159ea
derekmauro
added a commit
to abseil/abseil-cpp
that referenced
this issue
Aug 1, 2024
This updates to a version of GoogleTest that fixes google/googletest#4581 for downstream users of rules_python Cherry-pick of d0159ea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the issue
Forgive me if this has already been reported.
In 1.15.0 of googletest, when using Bzlmod and rules_python to register a toolchain, this line in googletest's MODULE.bazel interferes with any other subsequently registered toolchains. This is consistent with this disclaimer:
Given that this makes googletest impossible to use in a repository with both C++ and Python, it would be great to see this line removed.
Steps to reproduce the problem
What version of GoogleTest are you using?
1.15.0
What operating system and version are you using?
macOS 14.5
What compiler and version are you using?
python
What build system are you using?
N/A
Additional context
No response
The text was updated successfully, but these errors were encountered: