Remove GTEST_HAS_STD_STRING #2456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzkry
force-pushed
the
gtest-port-clean-up_breaking-changes
branch
5 times, most recently
from
29e9f27
to
998732d
Compare
|
273567737 |
|
@kuzkry There is another change in this PR, ::testing::tuple_size -> std::tuple_size. This one looks harder because there is internal code accumulated over the years that is still using ::testing::tuple_size. |
kuzkry
force-pushed
the
gtest-port-clean-up_breaking-changes
branch
from
998732d
to
838ea5c
Compare
|
Sure, done. |
kuzkry
changed the title
|
Trying again |
gennadiycivil
added a commit
that referenced
this pull request
Oct 11, 2019
…nges PiperOrigin-RevId: 274100752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit removes GTEST_HAS_STD_STRING. I think we can drop it, after all it's 2019 :)
2nd commit simply removes usings from the header, which is how all guidelines say
Both changes are backward incompatible. I would merge them though because README.md says the following about post 1.8.x releases:
and we don't quite need it, right?