-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[googletest] Output skip message #2517
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Closes google#2208 Previously, skip messages were invisible, so debugging skips was hard. Now we have this: ``` $ ./googletest/gtest_skip_test Running main() from /home/lesha/github/snarkmaster/googletest/googletest/src/gtest_main.cc [==========] Running 3 tests from 2 test suites. [----------] Global test environment set-up. [----------] 1 test from SkipTest [ RUN ] SkipTest.DoesSkip /home/lesha/github/snarkmaster/googletest/googletest/test/gtest_skip_test.cc:38: Skipped skipping single test [ SKIPPED ] SkipTest.DoesSkip (0 ms) [----------] 1 test from SkipTest (1 ms total) ... ```
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Looks good. Pulling this internally! |
PiperOrigin-RevId: 275869169
PiperOrigin-RevId: 275869169
PiperOrigin-RevId: 275869169
PiperOrigin-RevId: 275869169
Summary: Until [very recently](google/googletest#2517), `googletest` did not print the skip message in any shape or form, so nothing can possibly depend on us customizing the skip message here. The default is perfectly fine, let's keep it simple. Reviewed By: yfeldblum Differential Revision: D18051635 fbshipit-source-id: f7b889b0adf5e34a70c2579a34748bb159809b3c
to include the fix for google/googletest#2517 Signed-off-by: Kefu Chai <[email protected]>
to include the fix for google/googletest#2517 Signed-off-by: Kefu Chai <[email protected]>
to include the fix for google/googletest#2517 Signed-off-by: Kefu Chai <[email protected]>
Closes #2208
Previously, skip messages were invisible, so debugging skips was hard.
Now we have this: