Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GTEST_HAS_ABSL support into gmock cmake for MSVC #4576

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthieugleg
Copy link

Why this change

When building with MSVC, the sources of gtest are included directly in gmock rather than linking to gtest as a separate library. This resulted in GTEST_HAS_ABSL not being defined, causing gmock to miss linking with the necessary Abseil and RE2 libraries.

How this change fix this issue

  • Added conditional compilation definitions for GTEST_HAS_ABSL when building with MSVC.
  • Configured gmock and gmock_main to link with Abseil and RE2 dependencies explicitly.
  • Ensured that the dependencies are linked correctly by defining GTEST_HAS_ABSL and specifying the required libraries, thus resolving build and runtime issues.

* Added conditional compilation definitions for GTEST_HAS_ABSL in MSVC configuration.
* Configured and linked Abseil and RE2 dependencies when GTEST_HAS_ABSL is enabled.
Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant