Add GTEST_HAS_ABSL support into gmock cmake for MSVC #4576
+20
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change
When building with MSVC, the sources of
gtest
are included directly ingmock
rather than linking togtest
as a separate library. This resulted inGTEST_HAS_ABSL
not being defined, causinggmock
to miss linking with the necessary Abseil and RE2 libraries.How this change fix this issue
GTEST_HAS_ABSL
when building with MSVC.gmock
andgmock_main
to link with Abseil and RE2 dependencies explicitly.GTEST_HAS_ABSL
and specifying the required libraries, thus resolving build and runtime issues.