Skip to content

Commit

Permalink
Add flags specific to mac os system to workaround missing support of …
Browse files Browse the repository at this point in the history
…paths with spaces for runfiles. More information about the issue can be found in bazelbuild/bazel#4327.

PiperOrigin-RevId: 572980749
  • Loading branch information
mollyibot authored and copybara-github committed Oct 12, 2023
1 parent b5a3de2 commit 4d9f101
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ build --strategy=JavaDeployJar=local
build --strategy=JavaSourceJar=local
build --strategy=Turbine=local

# --experimental_inprocess_symlink_creation is used to workaround the missing
# support for paths with spaces https://github.com/bazelbuild/bazel/issues/4327.
# Remove the two flags after this issue is fixed in bazel new release.
build --enable_platform_specific_config
build:macos --experimental_inprocess_symlink_creation

test --test_output=errors

# Enable Java 11
Expand Down
2 changes: 1 addition & 1 deletion build_test_samples.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ if [[ $1 == "CI" ]]; then
(cd samples/guava && bazel build ...)

# Build wasm Hello World sample in its own workspace
(cd samples/wasm && bazel build ...)
(cd samples/wasm && bazel test ...)
fi
6 changes: 6 additions & 0 deletions samples/guava/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ build --strategy=JavaDeployJar=local
build --strategy=JavaSourceJar=local
build --strategy=Turbine=local

# --experimental_inprocess_symlink_creation is used to workaround the missing
# support for paths with spaces https://github.com/bazelbuild/bazel/issues/4327.
# Remove the two flags after this issue is fixed in bazel new release.
build --enable_platform_specific_config
build:macos --experimental_inprocess_symlink_creation

test --test_output=errors

# Enable Java 11
Expand Down
6 changes: 6 additions & 0 deletions samples/helloworld/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ build --strategy=JavaDeployJar=local
build --strategy=JavaSourceJar=local
build --strategy=Turbine=local

# --experimental_inprocess_symlink_creation is used to workaround the missing
# support for paths with spaces https://github.com/bazelbuild/bazel/issues/4327.
# Remove the two flags after this issue is fixed in bazel new release.
build --enable_platform_specific_config
build:macos --experimental_inprocess_symlink_creation

test --test_output=errors

# Enable Java 11
Expand Down
6 changes: 6 additions & 0 deletions samples/wasm/.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ build --strategy=JavaDeployJar=local
build --strategy=JavaSourceJar=local
build --strategy=Turbine=local

# --experimental_inprocess_symlink_creation is used to workaround the missing
# support for paths with spaces https://github.com/bazelbuild/bazel/issues/4327.
# Remove the two flags after this issue is fixed in bazel new release.
build --enable_platform_specific_config
build:macos --experimental_inprocess_symlink_creation

test --test_output=errors

# Enable Java 11
Expand Down
4 changes: 0 additions & 4 deletions samples/wasm/src/test/java/com/google/j2cl/samples/wasm/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ package(
j2wasm_test(
name = "HelloWorldTest",
srcs = glob(["*.java"]),
tags = [
"local",
"manual",
],
deps = [
"@com_google_j2cl//:junit-j2wasm",
"@com_google_j2cl//samples/wasm/src/main/java/com/google/j2cl/samples/wasm:helloworld",
Expand Down

0 comments on commit 4d9f101

Please sign in to comment.