-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host-built sample challenge not guaranteed to work in challenge container #384
Comments
Because the challenge runtime container and host build environment might diverge, link the sample challenge statically to give a higher likelihood that it can still run inside the challenge container.
Yeah, for the GoogleCTF we solved this by building all challenge binaries in a Dockerfile themselves: We should probably upstream that change. The original motivation for it was to allow anyone to rebuild all challenge binaries without depending on certain packages on the host. |
@sirdarckcat wdyt? |
I feel it's a little bit weird it's in a Makefile though (I would expect the Makefile to be called within the Dockerfile, not the other way around). We had some ideas about making all attachments "scratch" docker images iirc? Although I don't remember how we were planning to reference them |
In the local testing walkthrough there's an instruction to build the challenge binary using the host toolchain:
However, my Ubuntu 22.04 host builds a binary with a different glibc version requirement and this results in the challenge not running in the container:
The text was updated successfully, but these errors were encountered: