Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with asynchronously writing test files #19

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

PrabhuKathiresan
Copy link
Contributor

Hi Team,

I am able to see few lines of code gets added at the end of my test file that is generated as shown in the image.

image

As I tracked down this issue I found the writing the test file content asynchronously causing this issue and once I re wrote the code as

for (var i = 0; i < compiled.length; i++) {
              const testObj = compiled[i];
              fs.writeFileSync(join(options.writeTo, testObj.filename), testObj.contents)
            }

It seems to be working fine.

Please evaluate and make required changes

Thank you.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@PrabhuKathiresan
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@noahdietz noahdietz merged commit ba868a4 into google:master Jan 24, 2019
@noahdietz
Copy link
Collaborator

Thanks! Released in v1.2.4 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants