suricata: fix rust+C MSAN build #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust MSAN produces false positives when C clang version is not up to the latest version. See rust-lang/rust#107149
DavidKorczynski
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
If this affects all rust builds then I think it'd be nice with a fix for all -- unless rust-lang/rust#107149 is solved in the near term then maybe we can just wait until it that happens.
eamonnmcmanus
pushed a commit
to eamonnmcmanus/oss-fuzz
that referenced
this pull request
Mar 15, 2023
Rust MSAN produces false positives when C clang version is not up to the latest version. See rust-lang/rust#107149 Will fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55239&q=label%3AProj-suricata and such Should the fix be generic for other projects ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust MSAN produces false positives when C clang version is not up to the latest version.
See rust-lang/rust#107149
Will fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=55239&q=label%3AProj-suricata and such
Should the fix be generic for other projects ?