Check for malformed list when parsing hybrid topology metadata CPU list.

PiperOrigin-RevId: 643155348
google · Jul 10, 2024 · 5b27c28 · 5b27c28
1 parent 607f0b5
commit 5b27c28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/quipper/string_utils.cc b/src/quipper/string_utils.cc
@@ -69,7 +69,7 @@ bool ParseCPUNumbers(const std::string& cpus, std::vector<uint32_t>& result) {
     std::vector<std::string> range_tokens;
     SplitString(token, '-', &range_tokens);
 
-    if (range_tokens.size() > 2) {
+    if (range_tokens.empty() || range_tokens.size() > 2) {
       return false;
     }
 

diff --git a/src/quipper/string_utils_test.cc b/src/quipper/string_utils_test.cc
@@ -46,6 +46,7 @@ TEST(StringUtilsTest, ParseCPUNumbers) {
   EXPECT_THAT(result, ElementsAre(0, 1, 2, 3, 5, 6, 7));
   result.clear();
   EXPECT_FALSE(ParseCPUNumbers("", result));
+  EXPECT_FALSE(ParseCPUNumbers(",", result));
   EXPECT_FALSE(ParseCPUNumbers("a", result));
   EXPECT_FALSE(ParseCPUNumbers("0,1-2-3", result));
 }