-
Notifications
You must be signed in to change notification settings - Fork 56
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
.bazelrc: upate -W, read user.bazlrc. Fix missing include, uninitiali…
…zed variable. * .bazelrc: The warning silenced referencs zlib that had this warning fixed in 1.3, which is the version currently used by perf_data_converter. * Instead, add the warning about signed comparing as Google code prefers signed variables for safety, thus unsigned/signed comparison should not warn. * Add an optionally loaded user.bazelrc as that is very useful to add local options without having to edit the main .bazelrc Common practice and documented in bazel https://github.com/bazelbuild/bazel/blob/master/.bazelrc#L61 https://bazel.build/configure/best-practices#bazelrc-file * .gitignore: add user.bazelrc and *~ (common emacs backup file name) * string_utils.h: Fix a missing include <cstdint> for the use of uint32_t * perf_data_converter_test.cc: initialize an uninitialized variable the compiler can't figure out if it is set later and warns about.
- Loading branch information
Showing
4 changed files
with
8 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
# Require c++17 for c++ files. | ||
build --cxxopt='-std=c++17' | ||
# Disable warnings building zlib. | ||
build --copt='-Wno-deprecated-non-prototype' | ||
build --copt='-Wno-sign-compare' | ||
|
||
# Disable Bzlmod, a new external dependency management system on by default | ||
# since Bazel 7.0.0. This breaks compilation of protobuf by pulling in an older | ||
# version than what is specified in WORKSPACE. | ||
# TODO(b/319726507): Remove this when we have a better fix or move to Bzlmod. | ||
build --noenable_bzlmod | ||
|
||
# Load user-specific configuration, if any. | ||
try-import %workspace%/user.bazelrc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,8 @@ | |
*.d | ||
*.o | ||
*.log | ||
*~ | ||
user.bazelrc | ||
|
||
quipper | ||
perf_converter | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters