-Add -g option to save sample indices following Go's PGO requirements #171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting perf.data,
PerfDataConverter::GetOrCreateBuilder
creates the event name usingevent_type.name()
, adding an underscore and saving it inevent_name
. It then sets the type of the sample toevent_name + "sample"
(e.g. "cycles:u_sample").The problem is that when using the converted perf.data with Go's PGO, it complains that the profile should have at least one of the indices with type/unit of samples/count or cpu/nanoseconds (https://go.dev/doc/pgo#alternative-sources). This adds the -g option to save the sample indices following Go's PGO requirements.