Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove six: Replace six.string_types and six.integer_types, etc. #541

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

dbieber
Copy link
Member

@dbieber dbieber commented Sep 20, 2024

This PR includes:

  • assuming Python 3 for test skipping
  • assuming Python 3 for fire's various type checks
  • assuming Python 3 for imports (like asyncio)
  • assuming Python 3 for getting function signatures
  • six is no longer considered a hidden module (and so if a user of fire has six in their globals when they call Fire(), six will now show up where it used to be hidden)

This PR does not remove six from console/ code.

@dbieber dbieber changed the title remove six: Replace six.string_types and six.integer_types remove six: Replace six.string_types and six.integer_types, etc. Sep 20, 2024
@dbieber dbieber merged commit 5d0706d into master Sep 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant