-
Notifications
You must be signed in to change notification settings - Fork 22
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix workflow graph nodes are not centered within a group
Context: We calculate the graph height by default by calculating the topmost/bottommost node's Y coordinate (center point) and then adding half of the default node height to it (to adjust for the center point) and then adding the default paddings and margins. The error happens when the nodes are custom -> their height does not equal the default node height. To fix this, this CL modifies the topmost/bottommost point getter function to also calculate with an offset. PiperOrigin-RevId: 714032871
- Loading branch information
1 parent
973db2f
commit d3dfd9c
Showing
7 changed files
with
8 additions
and
6 deletions.
There are no files selected for viewing
Binary file modified
BIN
-11 Bytes
(100%)
src/app/demo_page/scuba_goldens/demo_page/chrome-linux/artifact-in-nested-loop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-10 Bytes
(100%)
src/app/demo_page/scuba_goldens/demo_page/chrome-linux/group-label-positioning.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-35 Bytes
(100%)
src/app/demo_page/scuba_goldens/demo_page/chrome-linux/recursive-graph.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-666 Bytes
(99%)
src/app/demo_page/scuba_goldens/demo_page/chrome-linux/select-nested-group.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+8 Bytes
(100%)
...pp/scuba_goldens/directed_acyclic_graph/chrome-linux/graph_group_with_label.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+8 Bytes
(100%)
...irected_acyclic_graph/chrome-linux/graph_group_with_label_and_treat_as_loop.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.