[derive] Implement an IntoBytes-based PartialEq/Eq derive #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard library's derive for `PartialEq` generates a recursive descent into the fields of the type it is applied to. This commit adds a `ByteEq` derive that generates an optimized, byte-oriented `PartialEq` implementation -- and a corresponding `Eq` implementation -- for types that implement `IntoBytes`. Instead of a recursive descent, the generated implementation performs a single slice comparison of the bytes of the two values being compared.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2285 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 16 16
Lines 6134 6134
=======================================
Hits 5365 5365
Misses 769 769 ☔ View full report in Codecov by Sentry. |
jswrenn
requested changes
Feb 2, 2025
| @@ -26,7 +26,7 @@ mod imp { | |||
| #[allow(unused)] | |||
| pub use { | |||
| ::core::{ | |||
| assert_eq, | |||
| assert_eq, assert_ne, | |||
There was a problem hiding this comment.
Did rustfmt perhaps miss this file? My intuition is that these two names should be on different lines.
There was a problem hiding this comment.
Surprised me too but that's how it seems to autoformat
There was a problem hiding this comment.
(If you put them on different lines it merges them)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard library's derive for
PartialEqgenerates a recursive descent into the fields of the type it is applied to. This commit adds aByteEqderive that generates an optimized, byte-orientedPartialEqimplementation -- and a correspondingEqimplementation -- for types that implementIntoBytes. Instead of a recursive descent, the generated implementation performs a single slice comparison of the bytes of the two values being compared.Closes #2274