Update safety comments for NonZeroXxx types
#620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes progress on #429
joshlf
force-pushed
the
nonzero-safety-docs
branch
from
932bea7 to
78d252c
Compare
jswrenn
reviewed
Nov 16, 2023
Comment on lines
+1835
to
+1836
| /// `NonZeroXxx` has the same layout and bit validity as its associated | ||
| /// primitive with the exception that 0 is not a valid instance. [1] |
There was a problem hiding this comment.
Can you also cite documentation that primitive number types are represented in two's complement? In principle, the value 0u8 in a programming language does not necessarily need to be represented as 0b0000_0000, but that's exactly what matters here.
There was a problem hiding this comment.
I can't actually find where this is documented (e.g. of u16 or i16). Are you able to find any documentation for it?
There was a problem hiding this comment.
Bump. Are you comfortable just merging as-is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #429