test: measure codecov, add missing tests

[antongolub]

• Tests pass

[antongolub]

@antonmedv,

I'm stuck. How to make this work on ubuntu?

if (test('question')) {
  let p = question('foo or bar? ', {choices: ['foo', 'bar']})

  setTimeout(() => {
    process.stdin.emit('data', 'fo')
    process.stdin.emit('data', '\t')
    process.stdin.emit('data', '\r\n')
  }, 100)

  assert.equal((await p).toString(), 'foo')
}

[antongolub]

And we also need a bit less interactive script to check https flow:

if (test('Eval script from https ref')) {
  let p = $`node zx.mjs https://medv.io/example-script.mjs` // Need another script
  setTimeout(() => p.kill(), 500)
}

just echo would be nice

[antonmedv]

What about using zx to test zx?

let script = `
echo(await question('foo or bar? ', {choices: ['foo', 'bar']}))
`
await $`node zx.mjs ${script}`

Same with server:

$`nc -l 8080`
await $`curl :8080`

[antongolub]

@antonmedv,
Got a trouble with nc, so the test hangs in an infinite loop. Kill the task plz

[antonmedv]

Killed.

[antonmedv]

With timeout? Problem we can’t merge them

[antongolub]

Missing Content-Length header. Fixed.

let script = await question('foo or bar? ', {choices: ['foo', 'bar']})
$node zx.mjs <<< ${script}

foo or bar? file:///Users/antongolub/projects/zx/src/index.mjs:99
    let output = new ProcessOutput({
                 ^
ProcessOutput [Error]: 
  at file:///Users/antongolub/projects/zx/test/index.test.mjs:123:4
  exit code: 13
  at ChildProcess.<anonymous> (file:///Users/antongolub/projects/zx/src/index.mjs:99:20)
  at ChildProcess.emit (node:events:520:28)
  at maybeClose (node:internal/child_process:1092:16)
  at Process.ChildProcess._handle.onexit (node:internal/child_process:302:5)

Still raises err code 13. Seems like a deadlock detection https://stackoverflow.com/questions/46914025/node-exits-without-error-and-doesnt-await-promise-event-callback/46916601#46916601

[antongolub]

Good news.

Wow, interesting: Nodejs v17 resolves localhost as IPv6 by default. nodejs/node#40537

[antongolub]

@antonmedv

One more nodejs v17 task is still hanging. Kill again plz. The rest are fine.

[antonmedv]

Killed.

[antongolub]

Any objections/suggestions on this PR? I think 99% code cov is a good point to start refactoring of zx inners.

[antonmedv]

Awesome work! Such test coverage is impressive!

[antonmedv]

Another thing for future improvements: make tests less dependent on each other and on common fixtures.

[antonmedv]

Will be cool to add cov report as comment to PRs.

[antonmedv]

Looks like c8 is missing from deps.

[antongolub]

I'm planning to decompose both tests and index.mjs inners. Thus they will become more atomic, loosely coupled, etc.