Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: getVersion with version from package.json #986

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

shevnv
Copy link
Contributor

@shevnv shevnv commented Dec 14, 2024

Fixes #971

import {getVersion} from 'zx'

const [major] = (getVersion() || '').split('.').map(Number)
if (major < 6)
  throw new Error('zx >= 6 is required')
  • Tests pass
  • Appropriate changes to README are included in PR

Copy link

google-cla bot commented Dec 14, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@antongolub
Copy link
Collaborator

antongolub commented Dec 15, 2024

Hey, @shevnv ,

  1. Let's resolve the version value in place. Or even VERSION like on lodash
  2. CLA acceptance is required

@antongolub antongolub added the ossln24 OSS Library Night 2024 label Dec 15, 2024
@antongolub
Copy link
Collaborator

@shevnv,
Do you need any help to finalize this?

@antongolub
Copy link
Collaborator

@shevnv,
I'll do the rest, if you dont mind.

@antongolub antongolub merged commit 88b8400 into google:main Dec 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ossln24 OSS Library Night 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: expose version
2 participants