feat: prepare jsr publish #989
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hey, @easymikey,
|
easymikey
force-pushed
the
prepare-jsr-publish
branch
2 times, most recently
from
4503181 to
0ebd232
Compare
src/core.ts
Outdated
| code: () => null, | ||
| signal: () => null, | ||
| message: () => ProcessOutput.getErrorMessage(error, self._from) | ||
| self._resolved = true |
There was a problem hiding this comment.
Let's keep the formatting for valid git blame.
There was a problem hiding this comment.
Sorry, I rebase another commit, everything is ok now
easymikey
force-pushed
the
prepare-jsr-publish
branch
2 times, most recently
from
6ad4f65 to
aa021be
Compare
|
@antongolub what do you think about adding test:coverege job to pull request action? |
We've already done. Line 89 in 14ff473 |
easymikey
force-pushed
the
prepare-jsr-publish
branch
from
3040ed4 to
aa021be
Compare
easymikey
force-pushed
the
prepare-jsr-publish
branch
from
aa021be to
3f6370c
Compare
easymikey
force-pushed
the
prepare-jsr-publish
branch
from
3f6370c to
7701870
Compare
Tell me, why are they launched only by the maintainer? |
| --ext=<.mjs> default extension | ||
| --install, -i install dependencies | ||
| --version, -v print current zx version | ||
| --help, -h print help | ||
| --repl start repl | ||
| --experimental enables experimental features (deprecated) | ||
|
|
There was a problem hiding this comment.
Let's keep this extra line.
scripts/build-jsr.mjs
Outdated
|
|
||
| import fs from 'node:fs' | ||
| import path from 'node:path' | ||
| const cwd = process.cwd() |
There was a problem hiding this comment.
Let's use root-based resolve, like here
Line 22 in 9f15fd4
| ) | ||
|
|
||
| fs.writeFileSync( | ||
| path.resolve(cwd, 'jsr.json'), |
| @@ -70,6 +70,7 @@ | |||
| "pretest": "npm run build", | |||
| "test": "npm run test:size && npm run fmt:check && npm run test:unit && npm run test:types && npm run test:license", | |||
There was a problem hiding this comment.
- "test": "... && npm run test:jsr"
- add
jsr.jsonto.gitignore
There was a problem hiding this comment.
Ahhh... its in temp. Ok, nvm
|
@antongolub Thanks for opportunity and your patience :) |
Fixes #980
Description
To support JSR: